New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scale and offset to temperature values to Modbus Climate #27045
Conversation
Thank you for your contribution thus far! 🎖 Since this is a significant contribution, we would appreciate you'd added yourself to the list of code owners for this integration. ❤️ Please, add your GitHub username to the For more information about "code owners", see: Architecture Decision Record 0008: Code owners. |
Looking forward to this feature. |
Also looking forward to this feature, especially because the current component is broken due to missing temperature unit :-) |
@frenck What does it take to get it merged? Thanks |
@adamchengtkc tested and found fully functional :-) |
Breaking Change:
No breaking change
Description:
This is my first PR and I have tried to read as many doc as possible. Please correct me if I done something wrong.
Related issue (if applicable): fixes #17873
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10480
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
..coveragerc
.If the code does not interact with devices: